[Build] - Reduce libsairedis build time by 16m #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemallin
force-pushed
the
dev/swig-gcc-fno-var-tracking-assignments
branch
from
e440f74
to
ebc07f7
Compare
kcudnik
previously approved these changes
Aug 16, 2024
mikemallin
force-pushed
the
dev/swig-gcc-fno-var-tracking-assignments
branch
from
ebc07f7
to
74f6f84
Compare
|
@kcudnik I've fixed the build issue, would it be possible to approve again? Thanks! |
mikemallin
force-pushed
the
dev/swig-gcc-fno-var-tracking-assignments
branch
from
74f6f84
to
61f1723
Compare
…ith GCC This improves compilation time by a total of 16m by disabling the GCC feature "Variable Tracking Assingments." The trade-off for disabling this feature is reduced debuggability if anyone needs to go through the object file pysairedis_wrap.o with a debugger. Please see the background below for details. This was identified via the following issue in the SWIG project: - swig/swig#2384 (comment) This is a performance issue in GCC specifically, not CLANG. Results: On a server with the following specifications, the build time for libsairedis went from 20m23s down to 3m50s. CPU: Intel(R) Xeon(R) Gold 6430 RAM: 1Tb DDR5 OS: Ubuntu 22.04 g++: g++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0 On an Apple MacBook Pro (with a Debian build VM), the build time for libsairedis also dropped significantly from 17m43s down to 3m46s CPU: Apple M3 Pro RAM: 18Gb OS: Debian 12 Bookworm g++: g++ (Debian 12.2.0-14) 12.2.0 Background: - https://gcc.gnu.org/wiki/Var_Tracking_Assignments - https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/6/html/developer_guide/ch-debug-vta#ch-debug-vta Signed-off-by: Mike RE Mallin <[email protected]>
mikemallin
force-pushed
the
dev/swig-gcc-fno-var-tracking-assignments
branch
from
61f1723
to
0440fc8
Compare
kcudnik
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add -fno-var-tracking-assignments to pysairedis_wrap.cpp when built with GCC
This improves compilation time by a total of 16m by disabling the GCC feature "Variable Tracking Assingments."
The trade-off for disabling this feature is reduced debuggability if anyone needs to go through the object file pysairedis_wrap.o with a debugger. Please see the background below for details.
This was identified via the following issue in the SWIG project:
This is a performance issue in GCC specifically, not CLANG.
Results:
On a server with the following specifications, the build time for libsairedis went from 20m23s down to 3m50s.
On an Apple MacBook Pro (with a Debian build VM), the build time for libsairedis also dropped significantly from 17m43s down to 3m46s
Background: